Hi, 1) User can use libkcapi to write program for finup/digest. 2) No, kernel test for finup (not sure). 3) We can test all callback of new hash tfm drivers added in kernel. 4) My driver had issue in finup path which is not caught by kcapi test program :) regards Harsh Jain regards Harsh Jain On Tue, May 31, 2016 at 4:35 PM, Stephan Mueller <smueller@xxxxxxxxxx> wrote: > Am Dienstag, 31. Mai 2016, 16:28:14 schrieb Harsh Jain: > > Hi Harsh, > >> Hi Stephen, >> >> Yes ,It's for Hash. The available API in library for hash update >> "_kcapi_md_update" uses "MSG_MORE" flag always set. It will not >> trigger driver's digest/finup implementation. We need something like >> that >> >> _kcapi_common_accept() >> send(handle->opfd, buffer, len, 0); ==> flag = 0. >> >> It will execute digest callback of selected tfm from User >> Space.(init->digest) Similarly >> >> _kcapi_common_accept() >> send(handle->opfd, buffer, len, MSG_MORE); >> send(handle->opfd, buffer, len, 0); >> >> It will execute finup callback of selected tfm. (init->update->finup). >> >> In that way we can test all callbacks from userspace. In future if you >> feel this use case important. You can add API's to implement this. > > Ok, I see that the finup code path is not exercised in the kernel by my > library. > > Why do you think that this code path should be tested by my test code? > > The test code shall verify that libkcapi works fine. > > Ciao > Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
