> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, May 31, 2016 7:55 AM > To: Benedetto, Salvatore <salvatore.benedetto@xxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 3/3] crypto: kpp - Add ECDH software support > > On Mon, May 09, 2016 at 10:40:41PM +0100, Salvatore Benedetto wrote: > > > > + do { > > + if (tries++ >= MAX_TRIES) > > + goto err_retries; > > + > > + ecc_point_mult(pk, &curve->g, priv, NULL, curve->p, ndigits); > > + > > + } while (ecc_point_is_zero(pk)); > > You might want to read this again. The original code did this because it > changed the private key in the loop, in your code priv is constant... Yep, I'll fix that. Thanks for reviewing. Salvatore -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
