Hi Herbert,
> On Fri, Apr 29, 2016 at 03:51:46PM +0300, Tudor Ambarus wrote:
> >
> > struct rsa_key {
> > + u8 *n;
> > + u8 *e;
> > + u8 *d;
> > + dma_addr_t dma_n;
> > + dma_addr_t dma_e;
> > + dma_addr_t dma_d;
> > + size_t n_sz;
> > + size_t e_sz;
> > + bool coherent;
> > + gfp_t flags;
>
> Please don't put the DMA primitives in the generic helper. They
> should stay in the driver for now.
If I move the DMA primitives to the driver context,
I can't assure software coherency enforcement in rsa helper.
If so, after the ANS.1 parsing, if a driver needs to enforce software
coherency, it will have to allocate coherent memory and copy
the ANS.1 parsed data there. Is this acceptable?
Thanks,
ta
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
