On 18 April 2016 at 16:41, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Apr 18, 2016 at 04:40:36PM +0800, Baolin Wang wrote: >> >> Simply to say, now there are many different hardware engines for >> different vendors, some engines can support bulk block but some can >> not (or no cipher hardware engine), then the dm-crypt can not know >> your hardware engine features. If the dm-crypt send one bulk block to >> low level, but the engine driver can not support bulk block, then it >> will crash. So we did the merging action in driver level not dm-crypt >> level. > > Surely we can handle it in the crypto API layer, just as we do GSO > in the network stack for drivers that can't handle TSO? Yes, it is similar. Thanks. > > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html