Re: [PATCH 2/7] crypto: sha256-mb - SHA256 multibuffer job manager and glue code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 24, 2016 at 01:25:58PM -0700, megha.dey@xxxxxxxxxxxxxxx wrote:
> From: Megha Dey <megha.dey@xxxxxxxxx>
> 
> This patch introduces the multi-buffer job manager which is responsible for
> submitting scatter-gather buffers from several SHA256 jobs to the
> multi-buffer algorithm. It also contains the flush routine to that's
> called by the crypto daemon to complete the job when no new jobs arrive
> before the deadline of maximum latency of a SHA256 crypto job.
> 
> The SHA256 multi-buffer crypto algorithm is defined and initialized in
> this patch.
> 
> Signed-off-by: Megha Dey <megha.dey@xxxxxxxxxxxxxxx>
> Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Reviewed-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>

sha1-mb still has the same issues that I complained about for the
aes-mb submission.  In particular, I don't like the use of shash
to handle what is really an async implmentation.

So I'd like to see this fixed first before we add any more copies
of this code.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux