RE: [PATCH 07/10] crypto: qat - remove duplicate ASN.1 parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Tadeusz Struk [mailto:tadeusz.struk@xxxxxxxxx]
> Sent: Sunday, March 20, 2016 4:56 PM
> To: Tudor-Dan Ambarus; herbert@xxxxxxxxxxxxxxxxxxx
> Cc: linux-crypto@xxxxxxxxxxxxxxx; smueller@xxxxxxxxxx; Horia Ioan Geanta
> Neag
> Subject: Re: [PATCH 07/10] crypto: qat - remove duplicate ASN.1 parser
> 
> On 03/18/2016 11:32 AM, Tudor Ambarus wrote:
> > Use the RSA's software implementation parser with
> > raw integer actions.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Tudor Ambarus <tudor-dan.ambarus@xxxxxxx>
> > ---
> >  drivers/crypto/qat/Kconfig                        |   3 +-
> >  drivers/crypto/qat/qat_common/Makefile            |  10 +-
> >  drivers/crypto/qat/qat_common/qat_asym_algs.c     | 265 +++++++---------
> ------
> >  drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1 |  11 -
> >  drivers/crypto/qat/qat_common/qat_rsapubkey.asn1  |   4 -
> >  5 files changed, 83 insertions(+), 210 deletions(-)
> >  delete mode 100644 drivers/crypto/qat/qat_common/qat_rsaprivkey.asn1
> >  delete mode 100644 drivers/crypto/qat/qat_common/qat_rsapubkey.asn1
> 
> Thanks for converting qat, but I'm working on adding support for the
> Chinese
> remainder algorithm, which gives us big performance improvement, so please
> do not change the qat driver just yet.
> Please just add a generic ANS.1 parser that would allow to obtain all
> components of the private key and I'll use it to add the handlers
> and remove the ASN.1 parsing from qat. I will then test it to make sure
> that it works fine before it is committed.

[ta] Ok.

> Thanks,
> --
> TS
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux