On Wed, Feb 24, 2016 at 05:51:44PM +0000, Giovanni Cabiddu wrote: > > +#define CRYPTO_SCOMP_DECOMP_NOCTX CRYPTO_ALG_PRIVATE I don't think this should be an scomp-specific flag. The point of noctx is that we don't need to do a request-specific vmalloc. Chances are that with hardware offload that you won't have to do such a vmalloc anyway. IOW acomp implementations are much more likely to be of the noctx type than scomp. This is how I think it should work: 1. There should be a single request_alloc function that allocates just the request without the vmalloc. 2. You then have to call an alloc_space function to allocate the vmalloc area (let's stop calling it ctx as it may lead to confusion with other contexts in the crypto API). The second step can obviously be skipped for the noctx case. Also instead of the private bit let's put this into the alg type: #define CRYPTO_ALG_TYPE_ACOMP 0x00000008 #define CRYPTO_ALG_TYPE_ACOMP_NOCTX 0x00000009 #define CRYPTO_ALG_TYPE_SCOMP 0x0000000a #define CRYPTO_ALG_TYPE_SCOMP_NOCTX 0x0000000b Now that we have killed crypto_hash we can shrink hash down to two types and move it to 0xe, freeing up the space for acomp/scomp. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
