On Mon, Mar 14, 2016 at 09:52:05PM +0000, Mark McKinstry wrote: > Your patch adds a dst_release() call to my suggested fix, but this is > problematic because the kfree_skb() call at tx_error already takes care > of releasing dst - via kfree_skb() > __kfree_skb() > skb_release_all() > > skb_release_head_state() > skb_dst_drop() > > refdst_drop() > dst_release(). In our scenario your patch results in > a negative refcount kernel warning being generated in dst_release() for > every packet that is too big to go over the vti. Hm. I've just noticed that my pmtu test does not trigger this codepath, so I did not see the warning. Seems like we do the pmtu handling too late, it should happen before we do skb_dst_set(). Also skb_scrub_packet() resets skb->ignore_df, so checking ignore_df after skb_scrub_packet() does not make much sense. I'll send an updated version after some more testing. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
