On 02/25/2016 04:11 PM, Herbert Xu wrote: > On Thu, Feb 25, 2016 at 03:56:31PM -0600, Tom Lendacky wrote: >> >> I can fix this in the driver by doing a memset to zero of the request >> context area during the import. But I guess I'm also wondering if there >> is an expectation/requirement that crypto_ahash_init() be called before >> doing an import? If there is the I can add that to the testmgr code >> instead. > > No init means wiping out the hash state so that a new hash can be > computed. Import means importing the hash state so that computation > can be continued from that point onwards. > > So they're independent of each other and you must be able to handle > an import without an init and vice versa. Thanks for the clarification Herbert. I'll send in a patch to perform the memset during the import. I know it's late in the cycle, but will you be able to apply it to the current cryptodev-2.6 tree which contains the ccp import/export patches? Thanks, Tom > > Cheers, > -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html