Hi David, I have converted the software_pkey to make use of the pkcs1pad template. The rsa.c is reverted back to what it was i.e. just math primitives and all padding is done in rsa-pkcs1padd.c software_pkey.c just allocates pksc1padd(alg,hash) This is incremental series on top of the current http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-rsa --- Tadeusz Struk (2): crypto: Add hash param to pkcs1pad crypto: remove paddings logic from rsa.c crypto/asymmetric_keys/software_pkey.c | 28 ++++ crypto/rsa-pkcs1pad.c | 182 ++++++++++++++++++++++++---- crypto/rsa.c | 210 +++++--------------------------- crypto/testmgr.c | 5 - include/crypto/akcipher.h | 7 - 5 files changed, 212 insertions(+), 220 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html