Hi! Shawn Guo writes: > On Thu, Feb 11, 2016 at 03:04:43PM +0100, Steffen Trumtrar wrote: >> Add documentation for the Freescale Security Controller (SCC) >> found on i.MX25 SoCs. >> >> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/crypto/fsl-imx-scc.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> >> diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> new file mode 100644 >> index 000000000000..9a15ab8da94f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/crypto/fsl-imx-scc.txt >> @@ -0,0 +1,17 @@ >> +Freescale Security Controller (SCC) >> + >> +Required properties: >> +- compatible : Should be "fsl,imx25-scc". >> +- reg : Should contain register location and length. >> +- interrupts : Should contain interrupt numbers for SCM IRQ and SMN IRQ. >> + >> +Example: >> + >> + scc: crypto@53fac000 { >> + compatible = "fsl,imx25-scc"; >> + reg = <0x53fac000 0x4000>; >> + clocks = <&clks 111>; >> + clock-names = "ipg"; > > Shouldn't these two be mentioned in properties list above too? > What is the current policy on clocks in bindings? There are some with and some without. Of course I can add them to the required properties if necessary. Thanks, Steffen -- Pengutronix e.K. | Steffen Trumtrar | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html