________________________________________ >From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >Sent: Monday, February 1, 2016 4:21 PM >To: Catalin Vasile >Cc: linux-crypto@xxxxxxxxxxxxxxx; linux-crypto-owner@xxxxxxxxxxxxxxx; Horia Ioan Geanta Neag; Cristian Stoica; Alexandru Porosanu; Catalin Vasile >Subject: Re: [RFC 1/2] crypto: tcrypt - Add acipher bandwidth tests support> >Catalin Vasile <cata.vasile@xxxxxxx> wrote: >> Signed-off-by: Catalin Vasile <cata.vasile@xxxxxxx>> >Please give a description of what your patch does here.> >> + case 600: >> + band_acipher("ecb(aes)", ENCRYPT, sec, NULL, 0, >> + speed_template_16_24_32);> >Rather than creating new test modes, which you would have to do >for every asynchronous type going forward, how about making a new >parameter that toggled this on and off? For example,> >modprobe tcrypt mode=601 band=1> Are you referring to modify the speed tests to include a flag to start bandwidth tests? If so, it sounds reasonable. >Thanks, >-- >Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >Home Page: http://gondor.apana.org.au/~herbert/ >PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Cata -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html