[v3 PATCH 0/3] crypto: algif_skcipher - fixes after skcipher conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 28, 2016 at 07:23:54AM -0800, Tadeusz Struk wrote:
> Hi Herbert,
> While testing the algif_aead async patch, I have rerun the async
> algif_skcipher tests and I have found some problems.
> There are three different issues around algif_skcipher and skcipher.
> Two are skcipher conversion related, and one is a bug in the
> algif_skcipher, not related to the conversion. It started to
> manifest itself after a fix the the qat driver.

OK I've decided to fix this differently.  The expectation of getting
back the original request is incorrect.  There are multiple places
where we will return a request other than the original.

We should probably change the API so that instead of passing the
struct crypto_async_request we just pass in void * instead.  That
way nobody could make this mistake.

Anyway, the following patches should fix the algif_skcipher issue.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux