On Tue, Jan 19, 2016 at 09:39:51AM -0800, Raj Ammanur wrote: > Thanks a bunch Herbert. I will try out the patch when you make it available. > > > Are there any thoughts for these other questions from you or anyone > else on the list, more > importantly regarding backlog handling in ESP ? > > > 2. When the pkts are put on the async work queue, the queue size is initialized > as 100 in cryptd_init_queue() in crypto/cryptd.c. Does anyone know how/why > 100 was picked ? This should probably be increased to match NAPI queue lengths. > 3. In cryptd_queue_worker(), the backlog->complete() callback is invoked with > -EINPROGRESS. In net/ipv4/esp4.c, there is no handling for EINPROGRESS > in esp_input_done()/esp_input_done2(). Am I reading the code correctly and > is there any expectation that ESP should support backlog and have backlog > handling ? Currently, the pkt just gets dropped as the EINPROGRESS is treated > as nexthdr and hence is invalid. IPsec does not use crypto backlogging so complete should never be called with EINPROGRESS. If the queue length is exceeded the packet will be dropped. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
