On Mon, Jan 18, 2016 at 05:06:05PM +0100, Jean Delvare wrote:
> I don't think it makes sense for a module to have a soft dependency
> on itself. This seems quite cyclic by nature and I can't see what
> purpose it could serve.
>
> OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
> much assumes that some incarnation of the "crc32c" hash algorithm has
> been loaded. Therefore it makes sense to have the soft dependency
> there (as crc-t10dif does.)
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Well caught. Patch applied, thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
