On Tue, Dec 15, 2015 at 12:27:23PM -0800, Tadeusz Struk wrote: > Since the times var is an signed int I think we should rather change the condition: I don't see what signed int has to do with anything. > > diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c > index 45c1739..864a5ea 100644 > --- a/drivers/crypto/qat/qat_common/qat_hal.c > +++ b/drivers/crypto/qat/qat_common/qat_hal.c > @@ -186,7 +186,7 @@ static int qat_hal_wait_cycles(struct icp_qat_fw_loader_handle *handle, > if (elapsed_cycles >= 8 && !(csr & (1 << ACS_ABO_BITPOS))) > return 0; > } > - if (!times) { > + if (!(0 < times)) { Oh, wow that's nasty! Why would you write it in such an obfuscated way? Plus it's buggy and wrong... What on earth. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html