Am Montag, 14. Dezember 2015, 20:52:19 schrieb Herbert Xu: Hi Herbert, >On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: >> Herbert, alg_bind currently blacklists one bit in the mask and type bit >> array. Shouldn't we instead white-list the allowed bits? > >Well a bogus mask shouldn't lead to the warning anyway. > >The warning in question is triggered only if crypto_schedule_test >returns NOTIFY_OK, which can only happen if try_module_get fails, >kzalloc fails, or if kthread_run fails. All of these would be >real bugs (well except for the kzalloc failure perhaps). But with the given code, when you remove the bogus mask setting (which in turn leaves it as 0), the code works flawless. > >Thanks, Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
