Hi Herbert, On 4 December 2015 at 15:28, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > Andrew Zaborowski <andrew.zaborowski@xxxxxxxxx> wrote: >> >> +static inline struct crypto_akcipher *crypto_spawn_akcipher( >> + struct crypto_akcipher_spawn *spawn) >> +{ >> + return crypto_spawn_tfm2(&spawn->base); >> +} >> + >> +static inline void crypto_drop_akcipher(struct crypto_akcipher_spawn *spawn) >> +{ >> + crypto_drop_spawn(&spawn->base); >> +} >> + >> +static inline struct akcipher_alg *crypto_spawn_akcipher_alg( >> + struct crypto_akcipher_spawn *spawn) >> +{ >> + return container_of(spawn->base.alg, struct akcipher_alg, base); >> +} >> + >> +static inline struct crypto_akcipher *crypto_spawn_akcipher( >> + struct crypto_akcipher_spawn *spawn) >> +{ >> + return crypto_spawn_tfm2(&spawn->base); >> +} > > You're defining crypto_spawn_akcipher twice. This also means that > you didn't even bother compiling it. The chunk that removed crypto_spawn_akcipher ended up in patch 4/4 because I messed up the rebase, oops. I'll fix this. I did compile and test. Best regards -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html