Re: [PATCH] crypto: rockchip/crypto - fix possible deadlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 28, 2015 at 01:48:53AM +0100, Heiko Stübner wrote:
>
> @@ -169,9 +169,10 @@ static irqreturn_t rk_crypto_irq_handle(int irq, void *dev_id)
>  {
>  	struct rk_crypto_info *dev  = platform_get_drvdata(dev_id);
>  	u32 interrupt_status;
> +	unsigned long flags;
>  	int err = 0;
>  
> -	spin_lock(&dev->lock);
> +	spin_lock_irqsave(&dev->lock, flags);

You don't need to disable IRQs in an IRQ handler.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux