Re: [PATCH] nx-842: Ignore bit 3 of condition register returned by icswx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 17, 2015 at 10:00:20PM +0800, Herbert Xu wrote:
> On Fri, Oct 30, 2015 at 03:43:01PM -0700, Ram Pai wrote:
> > icswx occasionally under heavy load sets bit 3 of condition register 0.
> > It has no software implication.
> > 
> > Currently that bit is interpreted by the driver as a failure, when
> > it should have calmly ignored it.
> > 
> > Signed-off-by: Ram Pai <linuxram@xxxxxxxxxx>
> 
> Your patch is corrupted:
> 
> $ patch -s -p1 < .git/rebase-apply/patch 
> patch: **** malformed patch at line 21: To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> $

Herbert, There were some comments about the patch on the ppc mailing
list.  

There are times this bit could be set and could be used by its
consumers; depending on how the RFC is implemented by the hardware. The
RFC does allow the hardware to assign meaning to that bit; though no
hardware currently exploits that feature. However from a software point
of view, we probably should not ignore the bit entirely. So please
ignore this patch till we come with a better solution.

RP

> -- 
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

-- 
Ram Pai

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux