On Sun, 18 Oct 2015 17:50:47 +0100 Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > The following series fixes the CAAM hash driver, allowing it to work > with the previously merged "crypto: ahash - ensure statesize is non- > zero" patch. > > This is non-trivial, because CAAM exports a huge 1600 bytes of data, > which, if we set .statesize to this, still results in the core code > rejecting the driver. So, we need to shrink the amount of state > exported. > > The first, most obvious one to get rid of is the export of the > caam_hash_ctx structure, which is shared between the socket being > exported from and imported to - copying it away and back again was > a complete no-op. > > The second is that we don't need to export both pending-bytes buffers. > Only one will be in use at any time. > > A problem was encountered while testing, where the size of the pending > bytes buffer was not added to the scatterlist with the correct length. > This is also fixed in this series, by patch 3. This bug was introduced > by a prior commit trying to fix a tcrypt error. However, the change is > wrong, but I have to question whether the test was correct or not - the > backtrace contains a function "test_ahash_pnum" which doesn't seem to > exist in mainline, nor does it seem to exist in any previous mainline > kernel. > > Version 2 of this series addresses a mismerge in patch 5 of the > original series, and adds further information to patch 3. > > Further testing with tcrypt showed up a problem identified by the > DMA API debugging (different to the original one referred to in > patch 3) where we leak DMA mappings. > > drivers/crypto/caam/caamhash.c | 101 +++++++++++++++++++++++++++++------------ > 1 file changed, 71 insertions(+), 30 deletions(-) > > -- > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. Russell, Thanks for putting these patches together. I tested the contents successfully with OpenSSL/AF_ALG and i.MX6. Tested-by: Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx> -- Victoria Milhoan <vicki.milhoan@xxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
