Re: [PATCH 0/6] Sparse related fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 18 Oct 2015 18:30:39 +0100
Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:

> Continuing on from the previous set of 18 patches, I also fixed a
> number of sparse problems and other cleanups.  I don't deem these
> suitable for -rc merging, especially now that we're basically at
> -rc6.
> 
> The first patch switches the driver over to appropriately using
> the relaxed IO accessors - this avoids calling out to the heavy
> barrier on every read and write operation, but only calling out on
> those which really matter.
> 
> We switch to using dma_addr_t for DMA addresses which are not accessed
> by hardware, and using gfp_t for the get_free_page flags.  String-based
> MMIO accesses are used instead of plain memcpy()/memset() which prevents
> us potentially stumbling over GCC optimisations that it thinks it may
> make with these functions.
> 
> We convert as much of the hardware state to __le32 endian markings,
> and use cpu_to_le32() as appropriate.  A number of places are left
> unfixed, as we temporarily store CPU native endian values at these
> locations; these warnings should not be fixed (basically, only
> appropriate sparse warnings should be fixed without penalising code.)

To the whole series:

Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>

> 
>  drivers/crypto/marvell/cesa.h   | 44 ++++++++++++++++++++---------------------
>  drivers/crypto/marvell/cipher.c | 13 ++++++------
>  drivers/crypto/marvell/hash.c   | 23 +++++++++++----------
>  drivers/crypto/marvell/tdma.c   | 42 ++++++++++++++++++++-------------------
>  4 files changed, 62 insertions(+), 60 deletions(-)
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux