Re: [PATCH v3 2/2] crypto: akcipher - Changes to asymmetric key API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 01, 2015 at 07:52:32AM -0700, Tadeusz Struk wrote:
> On 10/01/2015 06:45 AM, Herbert Xu wrote:
> > On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
> >>
> >>  struct akcipher_request {
> >>  	struct crypto_async_request base;
> >> -	void *src;
> >> -	void *dst;
> >> -	unsigned int src_len;
> >> -	unsigned int dst_len;
> >> +	struct scatterlist *src;
> >> +	struct scatterlist *dst;
> >> +	unsigned int out_len;
> > 
> > I think src_len/dst_len should be kept as the SG list may contain
> > more entries than the ones that you need to process.
> > 
> Herbert,
> Could you still apply it and the "Add mpi sgl helpers" on top
> and I'll add the src_len/dst_len in an incremental patch?
> It will make it easier for me.

Well I don't think we need out_len with dst_len being there so
this would be adding and then removing out_len for no good reason.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux