Hi Staphan: On Wed, Aug 19, 2015 at 11:48:05AM +0200, Stephan Mueller wrote: > > The recent AEAD change seems to trigger a need to change something in > testmgr.c. I ran my test tool trying to invoke all possible permutations of > cra_name and cra_driver_name ciphers and got the following: > > [11152.816179] alg: No test for gcm_base(ctr(aes-asm),ghash-generic) > (gcm_base(ctr(aes-asm),ghash-generic)) This is a bug in gcm_base. It should not use the driver name as its cra_name. I'll try to fix this. > [11154.278466] alg: No test for ccm_base(ctr(aes-asm),aes-asm) > (ccm_base(ctr(aes-asm),aes-asm)) > [11174.819535] alg: No test for gcm(aes-asm) (gcm_base(ctr(aes-asm),ghash- > clmulni)) > [11174.819610] alg: No test for rfc4106(gcm(aes-asm)) > (rfc4106(gcm_base(ctr(aes-asm),ghash-clmulni))) Ditto. gcm should also canonicalise aes-asm in its cra_name. > [11174.819654] alg: No test for seqiv(rfc4106(gcm(aes-asm))) > (seqiv(rfc4106(gcm_base(ctr(aes-asm),ghash-clmulni)))) This is different. We should definitely add tests for the IV generators. Obviously we can't test the randomness but we can certainly test for correctness. What we can do is reuse the test vectors for the underlying algorithms. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
