> For completeness, this patch also sets device drvdata to NULL after > the private structure is freed in talitos_remove(). [snip] > @@ -2745,6 +2754,7 @@ static int talitos_remove(struct platform_device > *ofdev) > iounmap(priv->reg); > > kfree(priv); > + dev_set_drvdata(dev, NULL); > > return 0; > } I just found this drvdata cleanup hasn't been required for a few years, due to the following commit: commit 0998d0631001288a5974afc0b2a5f568bcdecb4d Author: Hans de Goede <hdegoede@xxxxxxxxxx> Date: Wed May 23 00:09:34 2012 +0200 device-core: Ensure drvdata = NULL when no driver is bound Should I submit a v3 patch without this cleanup, assuming there aren't other changes requested? -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html