Re: [PATCH 6/8] crypto: qat - Convert to new AEAD interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 03, 2015 at 10:01:02AM -0700, Tadeusz Struk wrote:
>
> There is one problem that I missed before.
> We can shutdown a qat device and bring it back up via ioct.
> Before we shut the last device we also unregister the algorithms.
> Then we can bring them up again, but it fails without resetting the flags.

Good catch.  However it's not as simple as that.  We have a bigger
problem here.

For software implementations it's really easy because we use the
module reference count to prevent unregisters from happening while
there are tfms using it.

However for hardware devices this breaks down because you can remove
the device at any time.  So we'll have to come up with a way of
handling this without causing live tfms to explode.

FWIW the current qat code (and possibly other drivers) is buggy
because if you call unregister while there are still tfms using
it, it will BUG in the unregister call.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux