Re: [PATCH 3/3] crypto: qat - Add support for RSA algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 10, 2015 at 10:06:32AM -0700, Tadeusz Struk wrote:
>
> +	ctx->key_sz = mpi_get_size(pkey->n);
> +	if (!qat_rsa_enc_fn_id(ctx->key_sz)) {
> +		/* invalid key size provided */
> +		rsa_free_key(pkey);
> +		ctx->key_sz = 0;
> +		return -EINVAL;
> +	}

As we discussed a while ago, the hardware implementation must not
support a smaller feature set than the software implementation.

So please either add a software fallback for unsupported key sizes,
or ensure that the software implementation also rejects these key
sizes.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux