Hello Paul, On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote: > >> On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: >> > Hi Herbert, >> > >> > On Sun, 21 Jun 2015 16:27:17 +0800 >> > Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: >> > >> > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote: >> > > > >> > > > Indeed. Here is a patch fixing that. >> > > >> > > I think you should just kill COMPILE_TEST instead of adding ARM. >> > >> > The following patch is killing the COMPILE_TEST dependency. >> >> Patch applied. > > Just a heads up, this driver is still killing a couple of linux-next > builds today and for the past few days. > > drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function > 'of_get_named_gen_pool' [-Werror=implicit-function-declaration] > > http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/ > http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/ > > Missing dependency on CONFIG_OF_<blah> presumably. > I haven't looked at the series but <linux/genalloc.h> has a stub of_get_named_gen_pool() function if CONFIG_OF is not enabled [0]. So it seems that the problem is rather that the header is not being included in some file. > Paul. > -- > Best regards, Javier [0]: http://lxr.free-electrons.com/source/include/linux/genalloc.h#L131 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
