On Mon, Jun 15, 2015 at 04:52:51PM -0700, Victoria Milhoan wrote: > > + ret = clk_prepare_enable(ctrlpriv->caam_ipg); > + if (ret < 0) { > + dev_err(&pdev->dev, "can't enable CAAM ipg clock: %d\n", ret); > + return -ENODEV; > + } > + > + ret = clk_prepare_enable(ctrlpriv->caam_mem); > + if (ret < 0) { > + dev_err(&pdev->dev, "can't enable CAAM secure mem clock: %d\n", > + ret); > + return -ENODEV; > + } Shouldn't this disable caam_ipg? > + ret = clk_prepare_enable(ctrlpriv->caam_aclk); > + if (ret < 0) { > + dev_err(&pdev->dev, "can't enable CAAM aclk clock: %d\n", ret); > + return -ENODEV; > + } > + > + ret = clk_prepare_enable(ctrlpriv->caam_emi_slow); > + if (ret < 0) { > + dev_err(&pdev->dev, "can't enable CAAM emi slow clock: %d\n", > + ret); > + return -ENODEV; > + } And these two as well. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html