On Thu, Jun 04, 2015 at 03:15:19PM -0700, Tadeusz Struk wrote: > Hi Herbert, > On 05/22/2015 01:30 AM, Herbert Xu wrote: > > This patch makes use of the new AEAD interface which uses a single > > SG list instead of separate lists for the AD and plain text. > > The fact the src and assoc point to the same sgl causes some inconsistency. The input I'm getting is: > req->old = 1 > req->src_nents = 1 > req->src_len = 80 > req->dst_nents = 1 > req->dst_len = 80 > req->assoclen = 0 > > but > > req->assoc_nents = 1 > req->assoc_len = 80 > > I presume req->assoc is obsolete now and drivers need to use req->assoclen. right? > Currently I just loop over req->assoc to get the AD. Existing AEAD implementations should be completely unaware of the new interface because we recreate the old req->assoc in the crypto API. However, if you are creating a new AEAD implementation then yes you should stop using req->assoc and fetch it from req->src instead. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
