On Wed, Jun 03, 2015 at 03:44:14PM -0700, Tadeusz Struk wrote: > Change the existing rsa and public key code to integrate it > with the new Public Key Encryption API. > > Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxx> I'd like to see this split into multiple patches. First of all the new crypto_akcipher implementation should coexist with the existing code. That way the exiting users can be converted over one-by-one. Also you should implement the crypto_akcipher completely before converting anybody over, that means doing encoding/wrapping in addition to the crypto. That way we don't have to have craziness like converting in and out of MPI multiple times. Lastly you should consider adding an MPI helper that writes to an existing buffer instead of allocating a new one and copying it over. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
