On Wed, May 27, 2015 at 11:00:55AM +0200, Stephan Mueller wrote: > > Shouldn't there be a check for src == NULL here? I see the scatterwalk_ffwd > being used in the IV generators where they simply use the AD len and others. > For AF_ALG, those values may be set by user space in a deliberately wrong way > (e.g. more AD len than provided buffers). algif_aead should be verifying the user provided input. AFAICS it is doing exactly that. The crash we had previously were due to bugs in my algif_aead patch. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html