Am Montag, 18. Mai 2015, 17:21:31 schrieb Herbert Xu: Hi Herbert, >> +/* >> + * Equivalent function to get_random_bytes with the difference that this >> + * function blocks the request until the nonblocking_pool is initialized. >> + */ >> +int get_blocking_random_bytes_cb(void *buf, int nbytes, void *private, >> + void (*cb)(void *buf, int buflen, >> + void *private)) > >You can simplify this further and get rid of buf/nbytes. All >we need to know is whether the pool is ready. Everything else >can come from private. > So, the async function is now just a notification of the caller. Sounds good with me. >> + struct random_work *rw = NULL; >> + int ret = 0; > >I think this function should return 0 if the pool is ready now, >-EINPROGRESS if it's not (indicating that the callback will be >called when it is ready) and otherwise an error. Ok, will come in the next patch. Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
