Make the do_index and do_op functions static. They are used only internally by the 842 decompression function, and should be static. Reported-By: Fengguang Wu <fengguang.wu@xxxxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> Signed-off-by: Dan Streetman <ddstreet@xxxxxxxx> --- Oops, I missed making these static. Thanks for catching it! I left your Signed-off-by even though this patch covers do_index also (I assumed you agree with making both static :) lib/842/842_decompress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c index 6b2b45a..dbeb058 100644 --- a/lib/842/842_decompress.c +++ b/lib/842/842_decompress.c @@ -214,7 +214,7 @@ static int __do_index(struct sw842_param *p, u8 size, u8 bits, u64 fsize) return 0; } -int do_index(struct sw842_param *p, u8 n) +static int do_index(struct sw842_param *p, u8 n) { switch (n) { case 2: @@ -228,7 +228,7 @@ int do_index(struct sw842_param *p, u8 n) } } -int do_op(struct sw842_param *p, u8 o) +static int do_op(struct sw842_param *p, u8 o) { int i, ret = 0; -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html