Hi Stephan,
On 05/01/2015 12:24 AM, Stephan Mueller wrote:
>> +struct public_key;
>> >+struct public_key_signature;
> Wouldn't it make sense to move the struct definitions here and have them
> documented?
I'm not sure if they belong here. I think we can add some documentation
without moving them.
>> +struct pke_alg {
>> >+ int (*sign)(struct pke_request *pkereq);
>> >+ int (*verify)(struct pke_request *pkereq);
>> >+ int (*encrypt)(struct pke_request *pkereq);
>> >+ int (*decrypt)(struct pke_request *pkereq);
>> >+
>> >+ u8 pub_mpis; /* Number of MPIs in public key */
>> >+ u8 sec_mpis; /* Number of MPIs in secret key */
>> >+ u8 sig_mpis; /* Number of MPIs in a signature */
> May I ask that for such new structs we add some documentation? Currently, I am
> unclear on what MPIs are. E.g. if somebody needs to add, say, Curve 25519,
> what shall he add here?
Sure, I'll add some description.
>
> Up to here I am volunteering to add the documentation comments.
>
> But for the following functions, I am not sure how they are supposed to be
> used correctly. Thus, can you add the documentation for them or at least give
> me a hint so that I can add the documentation?
Same here, I'll add something. Thanks for volunteering.
You did a good job documenting the rest and your help will be appreciated.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
