On 4/25/2015 5:33 PM, Akinobu Mita wrote:
This patchset aims to fix several problems related to T10-PI support. These patches can be applied on top of Sagi's "[v1] Simlify dif_verify routines and fixup fileio protection information code" patchset.
Hi Akinobu, I have given this some more thought, This set adds DIF protected WRITE_SAME support. I don't think this will work with a real transport that offload DIF computation (at least not over RDMA - perhaps qlogic/emulex folks can comment on their devices). The problem is that the HBA does not have the write_same functionality you introduce here, i.e. generate multiple same protection fields for a single data block. We can require the fabrics drivers to do that (probably compensate in SW) or, we can have the write_same logic to live only in the core/backend code. In this case, for WRITE_SAME, have the fabrics generate/verify a single data block (one integrity field) like they do today, and then the core will expand it to the correct number of sectors using some form of sbc_dif_expand_same() I'm not sure which way is better... Martin? Nic? Thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
