On Thu, Apr 23, 2015 at 03:58:37AM +0200, Stephan Mueller wrote: > > So we have another memcpy just to copy that block into the IV field just to > have the KW cipher implementation copy it to some other location again? I do > not see the value of it. But you already do that extra copy anyway: + crypto_kw_scatterwalk_memcpy(&dst_walk, &dst_nbytes, block.A, + SEMIBSIZE, true); If you did it with an IV, this memcpy would disappear from the blkcipher code. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html