Hi Gregory, On Fri, 17 Apr 2015 15:01:01 +0200 Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote: > Hi Boris, > > On 17/04/2015 10:39, Boris Brezillon wrote: > > On Fri, 17 Apr 2015 10:33:56 +0200 > > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote: > > > >> Hi Jason, > >> > >> On Mon, 13 Apr 2015 20:11:46 +0000 > >> Jason Cooper <jason@xxxxxxxxxxxxxx> wrote: > >> > >>>> > >>>>> I'd appreciate if we'd look into it. I understand from on-list and > >>>>> off-list discussion that the rewrite was unavoidable. So I'm willing to > >>>>> concede that. Giving people time to migrate from old to new while still > >>>>> being able to update for other security fixes seems reasonable. > >>>> > >>>> Jason, what do you think of the approach above? > >>> > >>> I say keep it simple. We shouldn't use the DT changes to trigger one > >>> vice the other. We need to be able to build both, but only load one at > >>> a time. If that's anything other than simple to do, then we make it a > >>> Kconfig binary choice and move on. > >> > >> Actually I was planning to handle it with a Kconfig dependency rule > >> (NEW_DRIVER depends on !OLD_DRIVER and OLD_DRIVER depends > >> on !NEW_DRIVER). > >> I don't know how to make it a runtime check without adding new > >> compatible strings for the kirkwood, dove and orion platforms, and I'm > >> sure sure this is a good idea. > > ^ not > > > >> Do you have any ideas ? > > You use devm_ioremap_resource() in the new driver, so if the old one > is already loaded the memory region will be already hold and the new > driver will simply fail during the probe. So for this part it is OK. I like the idea :-). > > However, the old driver doesn't try to reserve the region, it directly > uses an ioremap(). So if the new driver is loaded first, then the old > one will manage to be loaded too. I think that just adding a > request_region()/release_region() (or converting the ioremap in a > devm_ioremap_resource() in the old driver would be enough. Absolutely. Unless someone is opposed to this solution I think I'll choose this solution. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
