On 04/14/2015 11:26 AM, Al Viro wrote:
>>> @@ -766,8 +765,7 @@ int sock_recvmsg(struct socket *sock, struct msghdr *msg,
>>> > >
>>> > > init_sync_kiocb(&iocb, NULL);
>>> > > ret = __sock_recvmsg(&iocb, sock, msg, size, flags);
>>> > > - if (-EIOCBQUEUED == ret)
>>> > > - ret = wait_on_sync_kiocb(&iocb);
>>> > > + BUG_ON(ret == -EIOCBQUEUED);
>> >
>> > NACK - PF_ALG type sockets support async operations and return -EIOCBQUEUED
>> > See skcipher_recvmsg_async() in crypto/algif_skcipher.c in net-next
> Its only caller is
>
> static int skcipher_recvmsg(struct socket *sock, struct msghdr *msg,
> size_t ignored, int flags)
> {
> return (msg->msg_iocb && !is_sync_kiocb(msg->msg_iocb)) ?
> skcipher_recvmsg_async(sock, msg, flags) :
> skcipher_recvmsg_sync(sock, msg, flags);
> }
>
> Note that !is_sync_kiocb() in there. Compare with init_sync_kiocb() in
> sock_recvmsg()...
The only problem is it calls init_sync_kiocb(&iocb, NULL) on a different iocb.
The one that isn't even passed to skcipher_recvmsg()
skcipher_recvmsg() checks is_sync_kiocb(msg->msg_iocb).
I just want to make sure that after the merging window is closed I can still
trigger aio_read on PF_ALG socket.
thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
