> On 11 apr. 2015, at 10:55, Arnd Bergmann <arnd@xxxxxxxx> wrote: > >> On Saturday 11 April 2015 09:41:08 Ard Biesheuvel wrote: >> Could you perhaps put the rules that build these modules inside a >> >> ifneq ($(armv8-ce-flags),-DARMV8_CE_DISABLED) >> ... >> endif > > How about something like this: > > ifeq ($(call as-option,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),) > $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) > else > ... > endif > > That would basically be a reimplementation of the missing "as-option-yn" > macro though, so we could also add that instead and do > > ifeq ($(call as-option-yn,-Wa$(comma)-mfpu=crypto-neon-fp-armv8),y) > $(warning ARMv8 Crypto Extensions need binutils 2.23 or higher) > else > ... > endif > Yes, that should work. Could we also move the CE objs to ce-obj-$() and put ifneq ($(ce-obj-y)$(ce-obj-m),) if <as check> obj-y += $(ce-obj-y) obj-m += $(ce-obj-m) else $(warning ...) endif endif around it so you only get the warning if you have selected any of these modules? In any case, I strongly prefer to leave the .S files themselves alone if at all possible Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
