On Thu, Apr 09, 2015 at 12:09:55PM +0200, Stephan Mueller wrote: > A cipher instance is added to the list of instances unconditionally > regardless of whether the associated test failed. However, a failed > test implies that during another lookup, the cipher instance will > be added to the list again as it will not be found by the lookup > code. > > That means that the list can be filled up with instances whose tests > failed. > > Note: tests only fail in reality in FIPS mode when a cipher is not > marked as fips_allowed=1. This can be seen with cmac(des3_ede) that does > not have a fips_allowed=1. When allocating the cipher, the allocation > fails with -ENOENT due to the missing fips_allowed=1 flag (which > causes the testmgr to return EINVAL). Yet, the instance of > cmac(des3_ede) is shown in /proc/crypto. Allocating the cipher again > fails again, but a 2nd instance is listed in /proc/crypto. > > The patch simply de-registers the instance when the testing failed. > > Signed-off-by: Stephan Mueller <smueller@xxxxxxxxxx> Patch applied. Thanks a lot! -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
