On Thu, Apr 02, 2015 at 05:13:23PM +0200, Stephan Mueller wrote: > > In crypto_remove_instance, the code dereferences inst->tmpl. If you say that > it is not guaranteed that the alg is always wrapped by an inst, wouldn't we > have a potential invalid pointer? This particular spot is always an instance because we just checked it. In any case the container_of buys us nothing and simply makes the code more convoluted. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
