On Mon, 2015-03-16 at 21:50 +1100, Herbert Xu wrote: > On Fri, Mar 13, 2015 at 11:38:21PM +0200, Ameen Ali wrote: > > fixing a syntax-error . > > > > Signed-off-by : Ameen Ali <AmeenAli023@xxxxxxxxx> > > Applied. The commit summary and the commit explanation are a bit misleading. This is not a syntax error: it actually compiles just fine with GCC 4.8. (I looked into that wondering whether this was stable material.) It's telling that the commit explanation doesn't contain a copy of the error message, which would have been very helpful if this really was a syntax error. The old code apparently works because the preprocessor converts time_before() into time_after(). And the code generated for time_after() will in its turn be wrapped in parentheses. That is, this generates valid syntax by, well, accident. So this could as well be labeled a style fix. A fix for a rather serious style defect, but still. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
