On 3/13/2015 9:46 PM, David Miller wrote: > From: Horia Geanta <horia.geanta@xxxxxxxxxxxxx> > Date: Fri, 13 Mar 2015 19:15:22 +0200 > >> Some crypto backends might require the requests' private contexts >> to be allocated in DMA-able memory. >> >> Signed-off-by: Horia Geanta <horia.geanta@xxxxxxxxxxxxx> > > No way. > > Upper layers should be absolutely not required to know about such > requirements. > > Such details _must_ be hidden inside of the crypto layer and drivers > and not leak out into the users of the crypto interfaces. If you look at patch 1/4: http://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg13428.html that's what's done for {aead,ablkcipher,ahash}_request_alloc(). Thus users (upper layers) that allocate the crypto requests using the crypto API are unaware of the requirement. However, ESP is not using aead_request_alloc(). This breaks the interface and thus some crypto implementation details are not transparent. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
