Re: [PATCH 00/10] omap3 crypto fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 26 February 2015 23:46:05 Aaro Koskinen wrote:
> Hi,
> 
> On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote:
> > This patch series fix crypto support for omap3 devices which
> > use DT.
> > 
> > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is
> > still disabled for N900.
> 
> (Please format your lines somewhere near < 76 chars,
> especially in commit logs, otherwise "git log" looks ugly on
> 80 char terminals.)
> 
> I tested these with stock bootloaders, and devices boot
> normally and I can now modprobe omap-aes (on N9 and N950) and
> omap-sham (on all three):
> 
> 	omap-aes 480c5000.aes: OMAP AES hw accel rev: 2.6
> 	omap-sham 480c3000.sham: hw accel on OMAP rev 0.9
> 
> However I get these when CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> is not set:
> 
> 	alg: hash: Chunking test 1 failed for omap-sha1
> 	alg: hash: Chunking test 1 failed for omap-md5
> 	alg: hash: Chunking test 1 failed for omap-hmac-sha1
> 	alg: hash: Chunking test 1 failed for omap-hmac-md5
> 
> But that's probably unrelated to this series. For patches 1-8,
> feel free to add:
> 
> Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> 
> A.

Hi, thanks for testing!

Now I'm happy that I can load omap-aes and omap-sham drivers on 
real n900 device, qemu n900 and after your tests also on real n9 
and n950 without any kernel crash or oops. Of course omap-aes is 
disabled on n900, but loading omap-aes.ko (accidentally) does not 
hurt.

It looks like there are other parts in md5 and sha broken, but 
first step is load & register all drivers without kernel crash. 
And this is working now.

-- 
Pali Rohár
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux