Hi Herbert,
On 02/27/2015 11:25 AM, Herbert Xu wrote:
> On Tue, Feb 03, 2015 at 03:59:48PM +0200, Cristian Stoica wrote:
>> test_aead_speed is written for sync algorithms without specifically
[...]
> Please fix it to test asynchronously instead.
Thanks for review.
I think that a fix for async aead requires a different test function as
is the case with test_cipher_speed/test_acipher_speed and also with
test_hash_speed/test_ahash_speed.
But I see a issue here with the current async tests:
int test_acipher_cycles(...)
{
for (i = 0; i < 8; i++) {
[...]
ret = do_one_acipher_op(req, crypto_ablkcipher_encrypt(req));
[...]
}
}
and in do_one_acipher_op we wait for completion of
crypto_ablkcipher_encrypt:
if (ret == -EINPROGRESS || ret == -EBUSY) {
struct tcrypt_result *tr = req->base.data;
ret = wait_for_completion_interruptible(&tr->completion);
}
Doesn't this defeat the purpose of async execution?
Cristian S.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
