Re: Nokia N900: omap aes is broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Pali Rohár <pali.rohar@xxxxxxxxx> [150224 09:52]:
> On Tuesday 24 February 2015 18:37:34 Tony Lindgren wrote:
> > * Pali Rohár <pali.rohar@xxxxxxxxx> [150224 09:42]:
> > > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote:
> > > > * Pali Rohár <pali.rohar@xxxxxxxxx> [150218 16:03]:
> > > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> > > > > @@ -3938,8 +3938,9 @@ int __init
> > > > > omap3xxx_hwmod_init(void)
> > > > > 
> > > > >  	if (r < 0)
> > > > >  	
> > > > >  		return r;
> > > > > 
> > > > > -	/* Register GP-only hwmod links. */
> > > > > -	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > > +//	/* Register GP-only hwmod links. */
> > > > > +//	if (h_gp && omap_type() == OMAP2_DEVICE_TYPE_GP) {
> > > > > +	if (h_gp) {
> > > > > 
> > > > >  		r = omap_hwmod_register_links(h_gp);
> > > > >  		if (r < 0)
> > > > >  		
> > > > >  			return r;
> > > > > 
> > > > > aes hwmod is defined in GP-only hwmod...
> > > > 
> > > > Doesn't this depend on the bootloader version of n900 to
> > > > work?
> > > > 
> > > > Regards,
> > > > 
> > > > Tony
> > > 
> > > Ok, it looks like second patch (omap_hwmod_3xxx_data.c)
> > > needs that aes-enabled bootloader.
> > 
> > OK we need some runtime detection somehow for what's enabled..
> > 
> 
> What about checking DT if omap-aes is disabled or not?

In general that's not a good solution as marking something with
status = "disabled" means the device is completely ignored and
we will never have the struct device entry created for it and
we can never idle it.

But in this case however, it may be the right thing to do if the
secure mode is using that device.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux