On 01/26/2015 11:20 AM, Stephan Mueller wrote: >> > Here we have two instances of crypto_aead algorithm, one the >> > rfc4106(gcm(aes)), whose setkey points to rfc4106_set_key(), and the >> > internal helper __gcm-aes-aesni (wrapped in by the cryptd interface), >> > whose setkey points to common_rfc4106_set_key(). If we would call >> > crypto_aead_setkey() on the parent from rfc4106_set_key() then we would >> > invoke the same rfc4106_set_key() function. It would be ok to call the >> > crypto_aead_setkey() on the child, but what's the point? > The point is to maintain an onion style framework that is coherent. All other > ciphers implement it (look at the generic gcm.c). > Hi Stephan, Ok, to keep it consistent is a good enough reason. I'll send v2 soon. Thanks, Tadeusz -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
