On 01/13/2015 03:07 PM, Herbert Xu wrote: > The patch ad511e260a27b8e35d273cc0ecfe5a8ff9543181 (crypto: qat - > Fix incorrect uses of memzero_explicit) broke hashing because the > code was in fact overwriting the qat_auth_state variable. > > In fact there is no reason for the variable to exist anyway since > all we are using it for is to store ipad and opad. So we could > simply create ipad and opad directly and avoid this whole mess. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Ok that looks better. Thanks. I think we should also remove the definition of struct qat_auth_state in line 107 and the #def above. Regards, Tadeusz -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
