On 01/04/2015 09:48 PM, Herbert Xu wrote: > memzero_explicit should only be used on stack variables that get > zapped just before they go out of scope. > > This patch replaces all unnecessary uses of memzero_explicit with > memset, removes two memzero_explicit calls altogether as the tfm > context comes pre-zeroed, and adds a missing memzero_explicit of > the stack variable buff in qat_alg_do_precomputes. The memzeros > on ipad/opad + digest_size/auth_keylen are also removed as the > entire auth_state is already zeroed on entry. Hi Herbert, Except the bad indentation in lines 1176 & 1183 :) this looks ok to me. Thanks. Acked-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
